Repository navigation
Prepare the drums package for PyPI - #5
Merged
Merged
Conversation
…iers, URLs; Apache-2.0 LICENSE text pending the owner's confirmation; MANIFEST.in
…, screenshot, verify, destroy); CHANGELOG for 0.1.0 to 0.2.5
…s that are not in this package
…d Publishing to PyPI on v* tags and TestPyPI on dispatch; CI; RELEASE.md with the owner's steps
…ar to drum); the import name stays drums
…ols refuses both, PEP 639)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prepares the SDK for
pip install drums-sdk(import name staysdrums; PyPI rejected the project namedrumsas too similar to the existingdrum). Nothing is uploaded by this PR; publishing happens when av*tag is pushed after merge (seeRELEASE.md).What is in here
pyproject.toml: distribution namedrums-sdk, version 0.2.5 (whatdrums.__version__and the public docs already say; see "Version" below), readme, classifiers, project URLs (drums.run, console.drums.run/docs, this repo),requires-python >= 3.9, no runtime dependencies. No console script: thedrumsCLI is on the unmergedmcp-serverbranch (drums mcp: two-layer MCP stdio server, drums CLI, Claude Code plugin #3), so it is not included.LICENSE: Apache License 2.0 text, ready. Owner decision pending: the SPDX line inpyproject.tomlis commented out and the release workflow refuses to publish until it is set (RELEASE.mdstep 0.1).pyproject.tomlhas declared Apache-2.0 since the first commit; this PR does not change that decision, it asks for it to be confirmed.README.md: a five-minute first page (install,DRUMS_URL+DRUMS_TOKEN, create a computer, screenshot, act, verify, destroy), links into the docs.CHANGELOG.mdfor 0.1.0 to 0.2.5..github/workflows/release.yml: on av*tag, build,twine check --strict, install the wheel on 3.9 to 3.13 and run the suite against it, then publish to PyPI through Trusted Publishing (environmentpypi,id-token: write). Onworkflow_dispatch, the same but to TestPyPI (environmenttestpypi). Gates: tag == version,__version__== pyproject, license line set. Fallback to aPYPI_API_TOKEN/TEST_PYPI_API_TOKENsecret when one exists; no tokens in the repo.ci.ymlruns the tests on PRs.RELEASE.md: the exact owner steps: register the pending Trusted Publisher, create the environments, TestPyPI first and verify in a clean venv, tag, verifypip install drums.docs/*.md) and an internal repo/branch name; they now point at console.drums.run/docs pages.Trusted Publisher fields (pypi.org -> Account -> Publishing -> add a pending publisher)
drums-sdkDrums-Labsdrums-python-sdkrelease.ymlpypi(TestPyPI:testpypi)Version
The brief asked for 0.2.0 to match the
v0.2.0git tag. That tag sits on the same commit as main, but the package there already says 0.2.5 (bumped five times, 2026-10-30 to 10-31), the operator-sent wheel wasdrums-0.2.5-py3-none-any.whl, and the public docs name 0.2.5. Publishing a lower number would make PyPI look older than the wheels people already have. So the first PyPI release is 0.2.5 and the tag to push isv0.2.5; thev0.2.0tag is left alone. If you want a different number, change it inpyproject.tomlanddrums/__init__.py(the workflow checks they agree).Audit
127.0.0.1(fake daemon in tests, local drumsd default). Paths are inside the guest desktop (/home/user,/etc/drums/token).Client.metrics()docstring describes a "cost" field computed from host price x wall time; that is a metric name, not a price.)DRUMS_TOKEN, notDRUMS_API_KEY; the README follows the code.Verified locally
python -m buildandtwine check --strict: pass. Wheel installed into clean venvs and the 32-test suite run against the installed package from outside the repo: Python 3.9.6, 3.10.22, 3.12.5, 3.13.4 all OK;import drums; drums.ClientOK on each.